Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix on CMakeFiles to let the package compile in Windows 10 - ROS Noetic #53

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix on CMakeFiles to let the package compile in Windows 10 - ROS Noetic #53

wants to merge 3 commits into from

Conversation

enricovillagrossi
Copy link

As discussed in #17 I modified the CMakeFile to let the package compile on Windows 10 and ROS Noetic.

This is ready for review and any feedback would be appreciated!

gavanderhoorn
gavanderhoorn requested changes Sep 5, 2022
View reviewed changes
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and my apologies for the delayed review.

Could we perhaps use target_compile_definitions(..) instead?

@gavanderhoorn
Copy link
Member

Annoying we don't have Windows CI here (#3).

(this is not directed at you @enricovillagrossi, just a mental note)

@enricovillagrossi
Copy link
Author

@gavanderhoorn I moved the flag -DNOGDI in target_compile_definitions(...). Let me know if it is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavanderhoorn gavanderhoorn gavanderhoorn requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enricovillagrossi @gavanderhoorn