[Windows][melodic-devel] Windows\MSVC port #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanyen
changed the title
|
The CI failure seems not to do with the change. The error message are as followed: |
|
@jrgnicho Hope I am pinging the correct owner. Any feedback would be appreciated! |
|
I've restarted the build. This is most likely due to the recent key change. |
|
@gavanderhoorn @jrgnicho Sorry to ping again. Any chance to take a look and make this PR move forward? |
jrgnicho
reviewed
Aug 26, 2019
| @@ -190,7 +190,7 @@ bool PlanningGraph::calculateJointSolutions(const TrajectoryPtPtr* points, const | |||
| bool success = true; | |||
|
|
|||
| #pragma omp parallel for shared(success) | |||
| for (std::size_t i = 0; i < count; ++i) | |||
| for (int i = 0; i < count; ++i) | |||
There was a problem hiding this comment.
Why change the iterator datatype here?
| @@ -26,7 +28,7 @@ struct IdGenerator; | |||
| * for the unique 'state'. Zero is reserved as a special value | |||
| */ | |||
| template <> | |||
| struct IdGenerator<uint64_t> | |||
| struct DESCARTES_CORE_DECL IdGenerator<uint64_t> | |||
There was a problem hiding this comment.
I'm not too familiar with MSVC toolchains so could you explain why this is needed?
| @@ -64,7 +64,7 @@ bool PlanningGraph::insertGraph(const std::vector<TrajectoryPtPtr>& points) | |||
|
|
|||
| // now we have a graph with data in the 'rungs' and we need to compute the edges | |||
| #pragma omp parallel for | |||
| for (std::size_t i = 0; i < graph_.size() - 1; ++i) | |||
| for (int i = 0; i < graph_.size() - 1; ++i) | |||
There was a problem hiding this comment.
Why change the iterator type?
| if(NOT MSVC) | ||
| add_compile_options(-std=c++11 -Wall -Wextra) | ||
| else() | ||
| add_definitions(-D__PRETTY_FUNCTION__=__FUNCTION__) |
There was a problem hiding this comment.
What does this definition do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change to enable
descartesto build by MSVC toolchains with https://aka.ms/ros installation.catkinguide.TR1headers by checking C++ standard version supported by compilers.[[gnu::unused]].-std=c++11 -Wall -Wextraby checking what compiler is in use.eigen_conversionsdependency since some cpp files consuming it. (e.g.,ikfast_moveit_state_adapter.cpp.)