Better validation of ip address for set_urg_ip #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the ipaddress library to validate the given ip-addresses. Don't use a loop to fill up missing zeros. Before the given ip was checked for their format which means that the format is like AAA.BBB.CCC.DDD. But it was never checked if it is actually a valid ip and not only in the correct format. Parsing it with ipaddress will ensure that the given ip is valid. Using zfill to fill missing zeros just feels nicer.
tonybaltovski
requested changes
May 31, 2020
| x = "0" + x | ||
| parsed += x | ||
| return parsed | ||
| ip = str(ipaddress.ip_address(argument)) |
There was a problem hiding this comment.
argument need to be cast to unicode, unicode(argument)
|
Thanks! Looks good but minor the one little change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the ipaddress library to validate the given ip-addresses.
Don't use a loop to fill up missing zeros.
Before the given ip was checked for their format
which means that the format is like AAA.BBB.CCC.DDD.
But it was never checked if it is actually a valid ip and not only
in the correct format.
Parsing it with ipaddress will ensure that the given ip is valid.
Using zfill to fill missing zeros just feels nicer.
Also remove some trailing whitespaces.