Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensor_msgs/Temperature and multi-channel readers #134

Open
wants to merge 4 commits into
base: noetic
Choose a base branch
from

Conversation

J-C-Haley
Copy link

Added a sensor_msgs/Temperature topic, giving published temperatures a timestamp. Prior float64 is preserved for now.

Added channel parameter to phidgets_temperature, allowing for multi-port readers.

@mintar
Copy link
Contributor

mintar commented Apr 9, 2022

Thanks! One of the checks is failing. This is because I added a check yesterday to ensure that the code formatting complies with clang-format. To fix this, follow the pre-commit Formatting Checks section of the README. If you run pre-commit run -a, it should fix the formatting automatically for you. Once you commit that, the check should pass.

@mintar mintar self-requested a review April 11, 2022 10:31
Copy link
Contributor

@mintar mintar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR. I've just reviewed it, and I think we should handle multiple channels the same way that they are handled in the other phidgets (for example, you can use the digital_output files as a template, reusing as much code as possible): One temperature class per channel, then one temperatures class to group all channels.

@mintar mintar added the ros1 label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants