Reformat json DeidentificationMethod #857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Was a single string separated by \\: "xx\\yy" * Now a json list ["xx", "yy"]
|
The .json produced by dcm2niix seems to have a mix between these two conventions. This newly modified way for DeidentificationMethod matches ImageType and BidsGuess. The old way matched SoftwareVersions, SequenceVariant, ScanOptions, etc. This new way is, however, more consistent with the current version of the accompanying PR for DeidentificationMethod/CodeSequence in bids-standard/bids-specification#1772 |
|
Closing this PR, if you want to reintroduce this, please re-base off of latest commit. See issue 861. |
Closed
This was referenced Sep 30, 2024
|
Now re-implemented in #871 as requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reformat json DeidentificationMethod
Addresses request by @yarikoptic in #813