Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterize key query fields in riem_measures() #48
base: main
Are you sure you want to change the base?
Parameterize key query fields in riem_measures() #48
Changes from 10 commits
ee51f9e
e95c3ec
2f6a39c
695875d
ca212f2
2a5f27e
3c358b4
60d8c28
d5a7f4c
8737611
1c8a136
a75b5b9
3b082f0
12aeea5
540fb46
fe048f4
b14e790
3b8bc96
ae205a3
2f0c7f9
b3c5dd4
115a373
045b229
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why, by the way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, the IEM download page defaults to routine and specials, but not HFMETAR. They describe their rationale:
It seems to me that IEM is specifying their desired default behavior. Tangential, I've also found this IEM news article.
Second, there is a bandwidth/size penalty (9.1x) and time penalty (6.4x) when selecting HFMETAR. It seems like an unsafe default.
I compared two single data points:
I'm sure our friends at IEM would appreciate the bandwidth savings from users who don't really need HFMETAR.
Third, as a token consumer of this data, my specific application is hampered by the extra time required to download HFMETAR data ... but I'd be happy to set a parameter if I actually needed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, it makes sense!
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.