Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid partial name matching #51

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

milanmlft
Copy link
Contributor

Hi @mpadge, thanks for the awesome package!
I just noticed I get some "partial match" warnings when running e.g. get_contributors():

Warning messages:
1: In ctb_code$login : partial match of 'login' to 'logins'
2: In ctb_issues$authors$login : partial match of 'login' to 'logins'
3: In ctb_issues$contributors$login : partial match of 'login' to 'logins'
4: In ctb_issues$authors$login : partial match of 'login' to 'logins'

(Note: I do have options(warnPartialMatchDollar = TRUE, warnPartialMatchAttr = TRUE, warnPartialMatchArgs = TRUE) set locally but I'd argue it's safer to not rely on partial matches 🙂).

This PR should take care of that. Happy to address any feedback or even for you to ignore this if you don't think it's important!

@mpadge mpadge merged commit b415b6a into ropensci:main Nov 29, 2024
7 of 8 checks passed
mpadge added a commit that referenced this pull request Nov 29, 2024
@milanmlft milanmlft deleted the milanmlft/avoid-partial-arg-matches branch November 29, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants