Skip to content

Commit

Permalink
Avoid partial name matching
Browse files Browse the repository at this point in the history
  • Loading branch information
milanmlft authored Nov 29, 2024
1 parent 636c2ac commit 9e0b6e5
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions R/github.R
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ get_contributors <- function (org, repo,
repo,
alphabetical = alphabetical
)
ctb_code <- ctb_code [which (!is.na (ctb_code$login)), ]
ctb_code <- ctb_code [which (!is.na (ctb_code$logins)), ]

Check warning on line 36 in R/github.R

View check run for this annotation

Codecov / codecov/patch

R/github.R#L36

Added line #L36 was not covered by tests
ctb_code$type <- "code"
if (!quiet) {
message (
Expand All @@ -59,12 +59,12 @@ get_contributors <- function (org, repo,
exclude_not_planned = exclude_not_planned
)

index <- which (!ctb_issues$authors$login %in% ctb_code$logins)
index <- which (!ctb_issues$authors$logins %in% ctb_code$logins)

Check warning on line 62 in R/github.R

View check run for this annotation

Codecov / codecov/patch

R/github.R#L62

Added line #L62 was not covered by tests
ctb_issues$authors <- ctb_issues$authors [index, ]

index <- which (
!ctb_issues$contributors$login %in%
c (ctb_code$logins, ctb_issues$authors$login)
!ctb_issues$contributors$logins %in%
c (ctb_code$logins, ctb_issues$authors$logins)

Check warning on line 67 in R/github.R

View check run for this annotation

Codecov / codecov/patch

R/github.R#L66-L67

Added lines #L66 - L67 were not covered by tests
)
ctb_issues$contributors <- ctb_issues$contributors [index, ]

Expand Down

0 comments on commit 9e0b6e5

Please sign in to comment.