fake vcr cassette #8
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelle
commented
Nov 17, 2020
| test_that("gh_organizations works", { | ||
| testthat::expect_type(gh_organizations(), "character") | ||
|
|
||
| testthat::expect_message(foo <- gh_organizations(), "Retrying") |
There was a problem hiding this comment.
see @sckott it's a case where I think it's easier to just wrap the whole test with use_cassette(). 🤔
There was a problem hiding this comment.
Note: when one wraps the whole test in use_cassette(), there's no straightforward way to "skip" the test.
maelle
commented
Nov 17, 2020
| Authorization: token af0e9f121c2b68b6957a9b325de64fe572b1fd9a | ||
| response: | ||
| status: | ||
| status_code: 502 |
There was a problem hiding this comment.
so in this cassette there is first a 502 and then a 200. in the test I use expect_message to make sure I get the 502 first.
maelle
force-pushed
the
fakecassettes
branch
from
4fbed97
to
473b384
Compare
maelle
force-pushed
the
fakecassettes
branch
from
473b384
to
778e565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.