Skip to content

Commit

Permalink
fix(package-discovery): Check for packages in webroot (#236)
Browse files Browse the repository at this point in the history
  • Loading branch information
Log1x authored and QWp6t committed Jul 8, 2022
1 parent b8b5ecc commit 1197ecf
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/Roots/Acorn/Application.php
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ protected function registerPackageManifest()
})
->merge([
$this->basePath(),
dirname(WP_CONTENT_DIR, 2),
get_template_directory(),
get_stylesheet_directory(),
])
Expand All @@ -277,6 +278,7 @@ protected function registerPackageManifest()
$this->getCachedPackagesPath()
);
});

$this->alias(FoundationPackageManifest::class, PackageManifest::class);
}

Expand Down

1 comment on commit 1197ecf

@f-liva
Copy link

@f-liva f-liva commented on 1197ecf Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

This commit in my opinion is wrong. I have a platform, at the ROOT (zero) level.
My WordPress with Acorn is in a subdirectory at level 1. Why should Acorn look at packages OUT of the wordpress directory? It creates a lot of conflicts for me, and this conceptually seems wrong.

Please sign in to comment.