Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused using declaration from gen_h1 #284

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Remove unused using declaration from gen_h1 #284

merged 1 commit into from
Feb 6, 2024

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Feb 6, 2024 •
edited
Loading

RFieldBase was moved out of the Detail namespace, but it's not actually used by the code.

@hahnjo
Remove unused using declaration from gen_h1
ccfe7df 
RFieldBase was moved out of the Detail namespace, but it's not actually
used by the code.
@hahnjo hahnjo requested review from jblomer and vepadulano February 6, 2024 10:23
@hahnjo hahnjo self-assigned this Feb 6, 2024
@hahnjo
Copy link
Member Author

hahnjo commented Feb 6, 2024

Alright, the CI doesn't build gen_h1 because rootbench-datafiles is OFF by default (but I tested locally that it builds now) and it seems there's no branch protection rules, so I'm going ahead with merging so it can be picked up by the noon root-benchmark job.

@hahnjo hahnjo merged commit 61211af into root-project:master Feb 6, 2024
1 check passed
@hahnjo hahnjo deleted the fix-gen_h1 branch February 6, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblomer jblomer Awaiting requested review from jblomer

@vepadulano vepadulano Awaiting requested review from vepadulano

Assignees

@hahnjo hahnjo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hahnjo