Skip to content

Commit

Permalink
Remove roofit option again
Browse files Browse the repository at this point in the history
With the conda nighlies being up-to-date again, we don't need the option
to disable RooFit anymore (it was introduced for the CI to be green,
as the RooFit benchmarks used new things that were not available in the
outdated nightlies).
  • Loading branch information
guitargeek committed Dec 15, 2023
1 parent 8107236 commit d479d99
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 11 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ jobs:
run: |
conda activate root-nightly
mkdir -p build && cd build
# The conda nightlies are not built with a cutting-edge ROOT version that the RooFit benchmarks require
cmake -Dcuda=OFF -Droofit=OFF ..
cmake -Dcuda=OFF ..
cmake --build .
- name: Run benchmarks
Expand Down
1 change: 0 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ endif()
project(rootbench)

option(cuda "Build benchmarks that run on CUDA GPUs" OFF)
option(roofit "Build RooFit benchmarks" ON)

include(CMakeToolsHelpers OPTIONAL)
include(ExternalProject)
Expand Down
8 changes: 3 additions & 5 deletions root/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
add_subdirectory(hist)
add_subdirectory(interpreter)
add_subdirectory(io)
add_subdirectory(hist)
add_subdirectory(math)
add_subdirectory(pyroot)
if (roofit)
add_subdirectory(roofit)
endif()
add_subdirectory(tree)
add_subdirectory(roofit)
add_subdirectory(tmva)
add_subdirectory(tree)
2 changes: 1 addition & 1 deletion root/roofit/histfactory/TestWorkspaces.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ TestWorkspaces::getWorkspace001(RooStats::HistFactory::HistoToWorkspaceFactoryFa
// in case the file is not found
if (bool bfile = gSystem->AccessPathName(inputFile.c_str())) {
std::cout << "Input file is not found - run prepareHistFactory script " << std::endl;
gROOT->ProcessLine("mkdir -p hf001");
gSystem->mkdir("hf001");
gROOT->ProcessLine(".! prepareHistFactory hf001");
bfile = gSystem->AccessPathName(inputFile.c_str());
if (bfile) {
Expand Down
4 changes: 3 additions & 1 deletion root/roofit/histfactory/benchHistFactory.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class TestData {
using namespace RooFit;

RooStats::HistFactory::HistoToWorkspaceFactoryFast::Configuration hfCfg;
std::unique_ptr<RooWorkspace> ws = TestWorkspaces::getWorkspace001(hfCfg);
ws = TestWorkspaces::getWorkspace001(hfCfg);

auto *mc = static_cast<RooStats::ModelConfig *>(ws->obj("ModelConfig"));

Expand All @@ -47,6 +47,8 @@ class TestData {
minimizationPath = std::make_unique<RooDataSet>(*m.getLogDataSet());
}

std::unique_ptr<RooWorkspace> ws;

// Dataset with the floating parameters as columns, and each call to getVal
// in the minimization path as rows.
std::unique_ptr<RooDataSet> minimizationPath;
Expand Down
2 changes: 1 addition & 1 deletion root/roofit/roofit/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ RB_ADD_GBENCHMARK(benchRooFitBackends
LIBRARIES Core MathCore RooFitCore RooFit)

if(cuda)
target_compile_definitions(benchRooFitBinned PRIVATE DO_BENCH_ROOFIT_CUDA)
target_compile_definitions(benchRooFitUnbinned PRIVATE DO_BENCH_ROOFIT_CUDA)
target_compile_definitions(benchRooFitBackends PRIVATE DO_BENCH_ROOFIT_CUDA)
endif()

Expand Down

0 comments on commit d479d99

Please sign in to comment.