Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF] Increase version number of RooCrystalBall #17506

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

guitargeek
Copy link
Contributor

Same reasoning as in commit bce142c from #12114.

Closes #17163.

Copy link

Test Results

    18 files      18 suites   3d 23h 54m 3s ⏱️
 2 687 tests  2 664 ✅ 23 💤 0 ❌
46 638 runs  46 638 ✅  0 💤 0 ❌

Results for commit b4e80eb.

@dpiparo dpiparo self-requested a review January 24, 2025 12:51
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, when a base class version change, one need to also change the derived classes version number :(. Thanks for the update.

@guitargeek guitargeek merged commit cf64237 into root-project:master Jan 24, 2025
21 checks passed
@guitargeek guitargeek deleted the issue-17163 branch January 24, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings from the deserialization of RooCrystalBall
3 participants