[ntuple] Make RNTupleDescriptor::Clone() return it by value #17500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 18 files 18 suites 4d 9h 14m 26s ⏱️ Results for commit fb02206. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
ntuple_desc_changes
branch
from
db24f2b to
e3882a8
Compare
jblomer
approved these changes
Jan 24, 2025
It doesn't make much sense to return the descriptor by unique_ptr, because it's not polymorphic and it's not copyable, so value+move semantics do a better job (and they are consistent with the other descriptors). Also marked all descriptor classes final because they're not meant to be overridden by users.
silverweed
force-pushed
the
ntuple_desc_changes
branch
from
e3882a8 to
fb02206
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make much sense to return the descriptor by unique_ptr, because it's not polymorphic and it's not copyable, so value+move semantics do a better job (and they are consistent with the other descriptors).
Also marked all descriptor classes final because they're not meant to be overridden by users.
Checklist: