[interpreter] Revert patch to move ClangConfig.cmake
#17354
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For standard CMake, Clang_DIR should include the lib/cmake/clang subdirectory suffix. This currently works only because Clad defines HINTS itself.
This is the name used in the Clang build system.
This is clearer and should also help in case ROOT is built as a subdirectory itself.
Test Results 17 files 17 suites 4d 2h 5m 10s ⏱️ For more details on these failures, see this check. Results for commit a843155. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 8a45c09 already modified the setup of
ClingConfig.cmake, this reverts the second part of commit 2b283cc and removes one downstream patch from our Clang sources.TODO:
builtin_llvm=OFF/builtin_clang=OFF, also for the individual commits.interpreter/llvm-project.tag(to be sequenced with other changes)