[RF] Change return type of RooRealVar::format() to std::string
#16954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 17 files 17 suites 4d 3h 8m 11s ⏱️ Results for commit a936fa3. ♻️ This comment has been updated with latest results. |
Returning a TString by raw pointer that the caller needs to delete is not memory safe and an outdated pattern, which merits a breaking change documented in the 6.36 release notes.
All tests are parametrized for the evaluation backend, but the parameter was not used for all likelihoods that were created in the tests. This commit fixes that, such that each test now consistently uses one evaluation backend.
guitargeek
force-pushed
the
tstring_ptr
branch
from
d4ec2bd to
a936fa3
Compare
lmoneta
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning a TString by raw pointer that the caller needs to delete is not memory safe and an outdated pattern, which merits a breaking change documented in the 6.36 release notes.