[CMake] Make it possible to pass existing CLAD_SOURCE_DIR
#16584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would address two annoyances I have at the same time:
1. One can now clone both `root` and `clad`, linking the source
directories together. This makes it much easier to try out changes
in clad in the context of ROOT.
2. ROOT can now configure and build without an internet connection,
even with `Dclad=ON`. This partially addresses root-project#11603.
Test Results 9 files 9 suites 1d 10h 10m 0s ⏱️ Results for commit b08905a. |
pcanal
approved these changes
Oct 2, 2024
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would address two annoyances I have at the same time:
One can now clone both
rootandclad, linking the source directories together. This makes it much easier to try out changes in clad in the context of ROOT.ROOT can now configure and build without an internet connection, even with
Dclad=ON. This partially addresses Disable automatic 'call home' in cmake when not needed #11603.