Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fix number of iterations in InterpreterStress::stressSTLDict() #13567

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jalopezg-git
Copy link
Contributor

It's not important, but I discovered by chance that InterpreterStress::stressSTLDict() was doing one iteration less than expected. Fix that.

Checklist:

  • tested changes locally

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you...

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@github-actions
Copy link

github-actions bot commented Aug 29, 2023

Test Results

       10 files         10 suites   2d 4h 22m 12s ⏱️
  2 484 tests   2 481 ✔️ 0 💤 3
23 763 runs  23 760 ✔️ 0 💤 3

For more details on these failures, see this check.

Results for commit c807a78.

♻️ This comment has been updated with latest results.

@jalopezg-git
Copy link
Contributor Author

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@hahnjo hahnjo force-pushed the fix-stressInterpreter branch from 3443289 to c807a78 Compare December 12, 2023 16:01
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@hahnjo hahnjo merged commit ff51641 into root-project:master Dec 12, 2023
13 of 16 checks passed
@jalopezg-git jalopezg-git deleted the fix-stressInterpreter branch December 12, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants