[df] Implement rule of five for RNodeBase and derived classes

tree/dataframe/inc/ROOT/RDF/RFilter.hxx

@@ -80,9 +80,14 @@ public:
       fLoopManager->Register(this);
    }
 
+   // Rule of five
+
    RFilter(const RFilter &) = delete;
    RFilter &operator=(const RFilter &) = delete;
-   ~RFilter() {
+   RFilter(RFilter &&) = delete;
+   RFilter &operator=(RFilter &&) = delete;
+   ~RFilter() final
+   {
       // must Deregister objects from the RLoopManager here, before the fPrevNode data member is destroyed:
       // otherwise if fPrevNode is the RLoopManager, it will be destroyed before the calls to Deregister happen.
       fLoopManager->Deregister(this);

tree/dataframe/inc/ROOT/RDF/RFilterBase.hxx

@@ -53,8 +53,13 @@ public:
    RFilterBase(RLoopManager *df, std::string_view name, const unsigned int nSlots,
                const RDFInternal::RColumnRegister &colRegister, const ColumnNames_t &columns,
                const std::vector<std::string> &prevVariations, const std::string &variation = "nominal");
-   RFilterBase &operator=(const RFilterBase &) = delete;
 
+   // Rule of five
+
+   RFilterBase(const RFilterBase &) = delete;
+   RFilterBase &operator=(const RFilterBase &) = delete;
+   RFilterBase(RFilterBase &&) = delete;
+   RFilterBase &operator=(RFilterBase &&) = delete;
    ~RFilterBase() override;
 
    virtual void InitSlot(TTreeReader *r, unsigned int slot) = 0;

tree/dataframe/inc/ROOT/RDF/RJittedFilter.hxx

@@ -41,7 +41,14 @@ class RJittedFilter final : public RFilterBase {
 
 public:
    RJittedFilter(RLoopManager *lm, std::string_view name, const std::vector<std::string> &variations);
-   ~RJittedFilter();
+
+   // Rule of five
+
+   RJittedFilter(const RJittedFilter &) = delete;
+   RJittedFilter &operator=(const RJittedFilter &) = delete;
+   RJittedFilter(RJittedFilter &&) = delete;
+   RJittedFilter &operator=(RJittedFilter &&) = delete;
+   ~RJittedFilter() final;
 
    void SetFilter(std::unique_ptr<RFilterBase> f);
 

tree/dataframe/inc/ROOT/RDF/RLoopManager.hxx

@@ -205,7 +205,7 @@ public:
    RLoopManager &operator=(const RLoopManager &) = delete;
    RLoopManager(RLoopManager &&) = delete;
    RLoopManager &operator=(RLoopManager &&) = delete;
-   ~RLoopManager() = default;
+   ~RLoopManager() override;
 
    void JitDeclarations();
    void Jit();

tree/dataframe/inc/ROOT/RDF/RNodeBase.hxx

@@ -52,7 +52,14 @@ public:
       : fLoopManager(lm), fVariations(variations)
    {
    }
-   virtual ~RNodeBase() {}
+
+   // Rule of five
+   RNodeBase(const RNodeBase &) = delete;
+   RNodeBase &operator=(const RNodeBase &) = delete;
+   RNodeBase(RNodeBase &&) = delete;
+   RNodeBase &operator=(RNodeBase &&) = delete;
+   virtual ~RNodeBase() = default;
+
    virtual bool CheckFilters(unsigned int, Long64_t) = 0;
    virtual void Report(ROOT::RDF::RCutFlowReport &) const = 0;
    virtual void PartialReport(ROOT::RDF::RCutFlowReport &) const = 0;

tree/dataframe/inc/ROOT/RDF/RRange.hxx

@@ -57,11 +57,15 @@ public:
       fLoopManager->Register(this);
    }
 
+   // Rule of five
+
    RRange(const RRange &) = delete;
    RRange &operator=(const RRange &) = delete;
+   RRange(RRange &&) = delete;
+   RRange &operator=(RRange &&) = delete;
    // must call Deregister here, before fPrevNode is destroyed,
    // otherwise if fPrevNode is fLoopManager we get a use after delete
-   ~RRange() { fLoopManager->Deregister(this); }
+   ~RRange() final { fLoopManager->Deregister(this); }
 
    /// Ranges act as filters when it comes to selecting entries that downstream nodes should process
    bool CheckFilters(unsigned int slot, Long64_t entry) final

tree/dataframe/inc/ROOT/RDF/RRangeBase.hxx

@@ -46,7 +46,12 @@ public:
    RRangeBase(RLoopManager *implPtr, unsigned int start, unsigned int stop, unsigned int stride,
               const unsigned int nSlots, const std::vector<std::string> &prevVariations);
 
+   // Rule of five
+
+   RRangeBase(const RRangeBase &) = delete;
    RRangeBase &operator=(const RRangeBase &) = delete;
+   RRangeBase(RRangeBase &&) = delete;
+   RRangeBase &operator=(RRangeBase &&) = delete;
    ~RRangeBase() override;
 
    void InitNode();

tree/dataframe/src/RFilterBase.cxx

@@ -34,9 +34,6 @@ RFilterBase::RFilterBase(RLoopManager *implPtr, std::string_view name, const uns
    }
 }
 
-// outlined to pin virtual table
-RFilterBase::~RFilterBase() {}
-
 bool RFilterBase::HasName() const
 {
    return !fName.empty();
@@ -61,3 +58,6 @@ void RFilterBase::InitNode()
    if (!fName.empty()) // if this is a named filter we care about its report count
       ResetReportCount();
 }
+
+// outlined to pin virtual table
+ROOT::Detail::RDF::RFilterBase::~RFilterBase() = default;

tree/dataframe/src/RLoopManager.cxx

@@ -1305,3 +1305,6 @@ ROOT::Detail::RDF::CreateLMFromFile(std::string_view datasetName, const std::vec
                                "\" in file \"" + inFile->GetName() + "\".");
 }
 #endif
+
+// outlined to pin virtual table
+ROOT::Detail::RDF::RLoopManager::~RLoopManager() = default;

tree/dataframe/src/RRangeBase.cxx

@@ -26,4 +26,4 @@ void RRangeBase::InitNode()
 }
 
 // outlined to pin virtual table
-RRangeBase::~RRangeBase() { }
+ROOT::Detail::RDF::RRangeBase::~RRangeBase() = default;