Address the rest of comments

root-project · Jul 5, 2024 · 3af49c5 · 3af49c5
1 parent 991120e
commit 3af49c5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/analyses/cms-open-data-ttbar/analysis.py b/analyses/cms-open-data-ttbar/analysis.py
@@ -1,8 +1,8 @@
 import argparse
-import os
 from pathlib import Path
 from time import time
 from typing import Optional, Tuple
+import multiprocessing
 
 import ml
 import ROOT
@@ -79,7 +79,7 @@ def parse_args() -> argparse.Namespace:
         help=(
             "Number of cores to use. In case of distributed execution this is the amount of cores per node."
         ),
-        default=1,
+        default = multiprocessing.cpu_count(),
         type=int,
     )
     p.add_argument(
@@ -357,8 +357,6 @@ def main() -> None:
         if args.inference:
             ROOT.RDF.Experimental.Distributed.initialize(load_cpp)
             if args.inference:
-                # TODO: make ml.load_cpp working on distributed
-                # ROOT.RDF.Experimental.Distributed.initialize(ml.load_cpp, "./fastforest")
                 ROOT.RDF.Experimental.Distributed.initialize(ml.load_cpp)
 
         else:

diff --git a/analyses/cms-open-data-ttbar/ml.py b/analyses/cms-open-data-ttbar/ml.py
@@ -1,7 +1,6 @@
 import os
 from dataclasses import dataclass
 from typing import Tuple
-
 from xgboost import XGBClassifier
 
 import ROOT