Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix async_get_last_action_log_entry in coordinator.py #79

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

danielcaceresm
Copy link
Contributor

The method async_get_last_action_log_entry is called from entity file and it fails due the method in coordinator has a leading underscore (as non-public member). I changed the method name to fix the issue.

@ronengr
Copy link
Owner

ronengr commented Nov 11, 2024

Thanks, i missed this.
Isn't it easier to change the call in the entity file to await self.coordinator._async_get_last_action_log_entry() instead of changing the function name?
this way the linter won't complain about docstring

@ronengr
Copy link
Owner

ronengr commented Nov 11, 2024

although maybe it is more "correct" to just add the docstring so the linter will be happy :-)

@danielcaceresm
Copy link
Contributor Author

I just added it!

@ronengr ronengr merged commit 3d423e4 into ronengr:main Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants