-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Value::from
and full code lines coverage
#498
Conversation
d44ba0f
to
122abf4
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #498 +/- ##
===========================================
+ Coverage 99.40% 100.00% +0.59%
===========================================
Files 78 78
Lines 10592 11053 +461
===========================================
+ Hits 10529 11053 +524
+ Misses 63 0 -63
☔ View full report in Codecov by Sentry. |
87d1e5a
to
041c6ec
Compare
?r @torkleyy It is possible - 100% code lines coverage 🎆 Do the |
eae54bd
to
d44413e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Looks good to me
This PR adds more tests to bring
ron
to 100% code lines coverage.The PR also implements convenient
From
impls forValue
, e.g.Value::from(bool)
andValue::from("my-str")
.CHANGELOG.md