Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine self-hosted coverage with clean codecov #486

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Aug 23, 2023

Follow-up to #483 - all we needed was cargo clean ... and two hours of debugging

* [ ] I've included my change in CHANGELOG.md

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 99.29% and project coverage change: +12.44% 🎉

Comparison is base (14734c1) 82.83% compared to head (8a9a545) 95.27%.
Report is 3 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #486       +/-   ##
===========================================
+ Coverage   82.83%   95.27%   +12.44%     
===========================================
  Files          74       74               
  Lines        9281     8852      -429     
===========================================
+ Hits         7688     8434      +746     
+ Misses       1593      418     -1175     
Files Changed Coverage Δ
src/error.rs 42.91% <25.00%> (-0.36%) ⬇️
src/parse.rs 96.61% <99.27%> (+21.29%) ⬆️
tests/481_number_underscores_suffixes.rs 99.79% <99.79%> (ø)
src/de/mod.rs 96.55% <100.00%> (+21.64%) ⬆️
src/ser/mod.rs 96.59% <100.00%> (+25.02%) ⬆️
src/ser/tests.rs 100.00% <100.00%> (+13.69%) ⬆️
tests/370_float_parsing.rs 100.00% <100.00%> (+1.78%) ⬆️

... and 48 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juntyr juntyr merged commit a293382 into ron-rs:master Aug 23, 2023
8 checks passed
@juntyr juntyr deleted the clean-codecov branch August 23, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants