fix: single kernel launch for exec driven transpose

romnn · Feb 11, 2024 · d916bdf · d916bdf
1 parent bdc864b
commit d916bdf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/benchmarks/src/transpose.rs b/benchmarks/src/transpose.rs
@@ -331,7 +331,10 @@ where
         rows,
         cols,
     };
+    // run once
     let mut result = transpose::<T, naive::Transpose<T>>(&tracer, rows, cols, &mut kernel).await?;
+
+    // repeat more times
     for _ in 0..repetitions {
         let (commands, traces) =
             transpose::<T, naive::Transpose<T>>(&tracer, rows, cols, &mut kernel).await?;

diff --git a/validate/src/simulate.rs b/validate/src/simulate.rs
@@ -340,15 +340,15 @@ pub mod exec {
                 #[derive(Debug, serde::Deserialize)]
                 struct TransposeInput {
                     dim: usize,
+                    #[allow(dead_code)]
                     repeat: Option<usize>,
                     variant: benchmarks::transpose::Variant,
                 }
-                let TransposeInput {
-                    dim,
-                    variant,
-                    repeat,
-                } = serde_json::from_value(values.clone()).map_err(parse_err)?;
-                benchmarks::transpose::benchmark::<f32>(dim, variant, repeat.unwrap_or(0)).await
+                let TransposeInput { dim, variant, .. } =
+                    serde_json::from_value(values.clone()).map_err(parse_err)?;
+                // hotfix .unwrap_or(0)
+                let repeat = 0;
+                benchmarks::transpose::benchmark::<f32>(dim, variant, repeat).await
             }
             "babelstream" => return Err(RunError::Skipped),
             other => {