Support count for <Plug>(qf_qf_previous) and friends #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A count was ignored for <Plug>(qf_qf_previous), <Plug>(qf_qf_next), <Plug>(qf_loc_previous), and <Plug>(qf_loc_next). This is a rather simple implementation, and thus may not yet behave entirely as expected. The count is only passed on to `:[cl]previous` and `:[cl]next`, but it is ignored when we wrap using `:[cl]first` and `:[cl]last`. So `100<Plug>(qf_qf_previous)` while at the top of the list will only jump to the end, not to the 100-to-last item in the list. Also, `:[cl]previous` and `:[cl]next` do not throw when the count is greater than the number of items moved, e.g. `:3previous` while on the 2nd entry in the list will move to the 1st entry, so it doesn't wrap in that case. I think both of these limitations are acceptable, but I'll gladly implement something a bit more complex to handle these cases. Wanted to check with you first, though, before doing unnecessary work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A count was ignored for (qf_qf_previous), (qf_qf_next), (qf_loc_previous), and (qf_loc_next). This is a rather simple implementation, and thus may not yet behave entirely as expected.
The count is only passed on to
:[cl]previousand:[cl]next, but it is ignored when we wrap using:[cl]firstand:[cl]last. So100<Plug>(qf_qf_previous)while at the top of the list will only jump to the end, not to the 100-to-last item in the list.Also,
:[cl]previousand:[cl]nextdo not throw when the count is greater than the number of items moved, e.g.:3previouswhile on the 2nd entry in the list will move to the 1st entry, so it doesn't wrap in that case.I think both of these limitations are acceptable, but I'll gladly implement something a bit more complex to handle these cases. Wanted to check with you first, though, before doing unnecessary work.
TODO: