Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix g:qf_shorten_path behaviour #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

newtonne
Copy link

The docs state that the default for g:qf_shorten_path is 1:

vim-qf/doc/qf.txt

Lines 396 to 398 in 7e65325

*'g:qf_shorten_path'*
Value: numeric ~
Default: 1 ~

But this isn't the case as it was defaulted to 0 in qf.vim.

Additionally, I believe the intention of this call:

call setqflist([], 'r', qf_list_title)

is to clear the qflist whilst retaining the title. However, it doesn't actually clear the qflist because the first argument is ignored:

setqflist({list} [, {action} [, {what}]])               setqflist()
                Create or replace or add to the quickfix list.

                If the optional {what} dictionary argument is supplied, then
                only the items listed in {what} are set. The first {list}
                argument is ignored.  See below for the supported items in
                {what}.

This meant that when g:qf_shorten_path was set to > 0, the list with shortened paths was being appended to the list with full paths, resulting in duplicates.

The docs state that the default for `g:qf_shorten_path` is 1:

https://github.com/romainl/vim-qf/blob/7e65325651ff5a0b06af8df3980d2ee54cf10e14/doc/qf.txt#L396-L398

But this isn't the case as it was defaulted to `0` in qf.vim.

Additionally, I believe the intention of this call:

```
call setqflist([], 'r', qf_list_title)
```

is to clear the qflist whilst retaining the title. However, it doesn't
actually clear the qflist because the first argument is ignored:

```
setqflist({list} [, {action} [, {what}]])               setqflist()
                Create or replace or add to the quickfix list.

                If the optional {what} dictionary argument is supplied, then
                only the items listed in {what} are set. The first {list}
                argument is ignored.  See below for the supported items in
                {what}.
```

This meant that when `g:qf_shorten_path` was set to > 0, the list with
shortened paths was being appended to the list with full paths,
resulting in duplicates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant