Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of using a CTE #295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add example of using a CTE #295

wants to merge 1 commit into from

Conversation

ianks
Copy link
Contributor

@ianks ianks commented Aug 21, 2019

This PR adds an example of using a CTE. I think examples like this are good to have because it illustrates how powerful ROM can be in advanced scenarios.

This example might be more fitting under some Advanced section, but currently, there is not one. Do you think tit would be worthwhile to do that or should I save that for a later PR?

@solnic
Copy link
Member

solnic commented Aug 30, 2019

This is very helpful, a couple of remarks though:

  • Reaching out to Sequel directly is possible but discouraged, because if something is not possible in rom-sql then it's a missing feature, and we gotta add it; however, it shouldn't of course block anybody from doing advanced stuff. It would be good to somehow explain this
  • It feels like this kind of stuff should be moved to "Advanced" section of SQL docs

WDYT?

@ianks
Copy link
Contributor Author

ianks commented Sep 3, 2019

Agree with advanced section and explanation that it is an escape hatch. I'll update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants