Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build stage to dev build instructions #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add build stage to dev build instructions #244

wants to merge 1 commit into from

Conversation

AntonOfTheWoods
Copy link

Fixes #243

ItsKDaniel
ItsKDaniel reviewed Aug 5, 2022
View reviewed changes
Copy link

@ItsKDaniel ItsKDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, it would be best to execute npm run generate-graphs before executing dev. Can you confirm if that works rather than building the whole app?

ItsKDaniel
ItsKDaniel reviewed Aug 5, 2022
View reviewed changes
README.md
@@ -6,8 +6,9 @@ This is the source code for the website. Note that the actual guide is now part

1. `npm install`
2. `npm run update-guide`
3. `npm run dev`
4. Open up http://localhost:3000
3. `npm run build`
Copy link

@ItsKDaniel ItsKDaniel Aug 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer #243 (comment)

Suggested change
3. `npm run build`
3. `npm run generate-graphs`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either this, or you change it to

  1. npm install
  2. npm run build
  3. npm run dev

As "build" also includes update-guide. The advantage is that is is easier for us to keep the build command stable and add additional steps there if they should prove necessary in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert left review comments

@ItsKDaniel ItsKDaniel ItsKDaniel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build instructions don't work
3 participants
@AntonOfTheWoods @ItsKDaniel @lukastaegert