Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct documentation - terraform import rollbar_user.* is to be done by email address, not user ID #395

Closed
wants to merge 1 commit into from
Closed

Conversation

magnetikonline
Copy link

@magnetikonline magnetikonline commented Apr 26, 2024

Description of the change

This fixes a problem in the documentation around importing existing Rollbar users into rollbar_user resources - import is not via user ID - but must be via email address.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Fixes (part of) issues in:

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer


```
$ terraform import rollbar_user.foo 238101
$ terraform import rollbar_user.some_dev [email protected]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lined up the example resource name and email address in the example above - clearer to the reader.

@pawelsz-rb pawelsz-rb self-requested a review April 30, 2024 06:01
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8842144592

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.097%

Totals Coverage Status
Change from base Build 8449956416: 0.0%
Covered Lines: 1480
Relevant Lines: 1607

💛 - Coveralls

@pawelsz-rb pawelsz-rb mentioned this pull request Apr 30, 2024
12 tasks
@pawelsz-rb
Copy link
Collaborator

pipeline failed, we need to check the permissions, thank you for flagging, addressing in #396

@pawelsz-rb pawelsz-rb closed this Apr 30, 2024
@magnetikonline magnetikonline deleted the fix-rollbar_user-import-docs branch April 30, 2024 06:25
@magnetikonline
Copy link
Author

Thanks @pawelsz-rb 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants