Removed JSON-js submodule and integrated the modified json3 directly #1135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR removes the only submodule in the workspace, a forked version of JSON-js @ https://github.com/rollbar/JSON-js and integrates it directly into the project.
The last time the code in the fork was changed is 2015, and given we only seem to use
json3
, it does not seem like we're using any of the modified code.Note
This was mainly done with the aim of making the move to a monorepo easier.
Type of change
Checklists
Development
Code review