Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed JSON-js submodule and integrated the modified json3 directly #1135

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

matux
Copy link
Contributor

@matux matux commented Mar 7, 2024

Description of the change

This PR removes the only submodule in the workspace, a forked version of JSON-js @ https://github.com/rollbar/JSON-js and integrates it directly into the project.

The last time the code in the fork was changed is 2015, and given we only seem to use json3, it does not seem like we're using any of the modified code.

Note

This was mainly done with the aim of making the move to a monorepo easier.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux requested review from waltjones and mudetroit March 7, 2024 17:02
@matux matux self-assigned this Mar 7, 2024
@matux matux merged commit 55cf3ca into master Mar 7, 2024
7 checks passed
@matux matux deleted the matux/subm branch March 7, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants