Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Connected App key.enc #32

Merged
merged 1 commit into from
May 19, 2021
Merged

Update Connected App key.enc #32

merged 1 commit into from
May 19, 2021

Conversation

waltjones
Copy link
Contributor

@waltjones waltjones commented May 13, 2021

Description of the change

Update encrypted key file for expired/renewed cert.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI

Related issues

ch82033

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@waltjones waltjones changed the title WIP: Update Connected App key.enc Update Connected App key.enc May 13, 2021
@waltjones waltjones requested review from bxsx, diegov and pawelsz-rb May 18, 2021 14:51
Copy link
Contributor

@bxsx bxsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's difficult to make a review for this PR. Could you provide more information (here or in CH) about source of encrypted key file? How can I be sure the updated file is correct?

@waltjones
Copy link
Contributor Author

@bxsx Apologies, my PR description wasn't the best on this one.

It is used here: https://github.com/rollbar/rollbar-sf-apex/blob/v2.4.0/.github/workflows/ci.yml#L24

So if it's wrong, CI will fail as in this PR (#31).

Copy link
Contributor

@bxsx bxsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation @waltjones.

@waltjones waltjones merged commit d1511d5 into master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants