Replace rollbar-ios with rollbar-apple #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matux
approved these changes
Jun 28, 2023
| return RollbarLevel_Warning; | ||
| } else if ([value caseInsensitiveCompare:@"error"] == NSOrderedSame) { | ||
| return RollbarLevel_Error; | ||
| } else if ([value caseInsensitiveCompare:@"critical"] == NSOrderedSame) { |
There was a problem hiding this comment.
Curious: You can't use the static funcs of the exported RollbarLevelUtil in RollbarLevel.h?
There was a problem hiding this comment.
I didn't see those. I'll take a look.
There was a problem hiding this comment.
Will update this in #169.
waltjones
added a commit
that referenced
this pull request
Jul 10, 2023
* Version 1.0.0-rc.0 * handle NSNull in json argument (#170) * support both web and native, and full rollbar.js config (#171) * Use platform specific imports for Rollbar.js (#172) * rename Rollbar.js file to Client.js * update ts type definitions * use platform specific import for Rollbar.js * feat: replace rollbar-ios with rollbar-apple (#175) * downgrade release from rc to beta * pin RollbarNotifier to 3.0.3 * update yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Replaces rollbar-ios with rollbar-apple for iOS native support.
Note: This PR contains breaking changes and merges to the 1.0 rc PR, #169.
Type of change
Related issues
Fixes: