Amended PR: Add listen new config param "minimum_level" error log. #46
Conversation
…e latest fixes to rollbar-php for CI
… you specify it by a particular commit
|
@ArturMoczulski It's cool need now release rollbar-php =) |
…test access_token in config_tes re #45
|
@ArturMoczulski Hi, when will it be released? |
| enabled: true | ||
| access_token: ~ # pulled from phpunit.xml | ||
| environment: 'rollbar-php-symfony-test-app' | ||
| minimum_level: 'info' |
There was a problem hiding this comment.
Is this the reason this PR was never merged?
|
Hi @Yozhef this is great. when will it be released? |
|
@jantenuccigsbla sorry but I don't now need to ask @ArturMoczulski. |
|
I think we should also ask @jessewgibbs why library for Top PHP framework has such a low priority for Rollbar company. Last release of this bundle was 1 year ago (2 Jan 2019). Now it doesn't support actual version of Rollbar library itself (v2). It doesn't support the actual version of Symfony framework (v5) which it is developed for. There is no tagged release even for recent already merged fixes. All proposed fixes by contributors are being considered for years. What's the point to make official Symfony Bundle and don't support it for years? Don't Rollbar company really have enough money to hire one dedicated PHP developer for this library? Rollbar is a commercial product which is used by many companies including mine. Is it acceptable from the product point of view? |
| @@ -31,6 +31,7 @@ matrix: | |||
|
|
|||
| before_install: | |||
| - composer self-update | |||
| - composer clear-cache | |||
There was a problem hiding this comment.
Why was this change made? Seems completely unnecessary.
There was a problem hiding this comment.
The head is here:
Change:
return new RollbarHandler(Rollbar::logger(), LogLevel::ERROR);
To:
return new RollbarHandler(Rollbar::logger(), $this->minimumLevel);
Because there are errors above the error equation, but in the config, lib has params minimum erorr level log.
|
I think this repository is dead = ( @ArturMoczulski if you don't want to do it, please pass it on to someone else. |
Amends #44
Test coverage for this is coming in #45