Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace removed enabled Gradle method calls with required properties #121

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

tmichaelreis
Copy link
Contributor

Description of the change

Gradle 8 no longer allows the xml.enbled true method call and now uses the xml.required= true property.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

#119

Checklists

Development

  • Lint rules pass locally
  • [N/A] The code changed/added as part of this pull request has been covered with tests
  • [N/A] All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@tmichaelreis tmichaelreis changed the title Replace removed enabled method calls with required properties Replace removed enabled Gradle method calls with required properties Dec 29, 2023
Copy link
Collaborator

@matux matux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@matux matux merged commit 0db0f26 into rollbar:main Jan 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants