fix: resolve #66

rollbar · Apr 15, 2021 · 5cae263 · 5cae263
1 parent 56970e7
commit 5cae263
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 13 deletions.
diff --git a/Demos/macosAppObjC/macosAppObjC/AppDelegate.m b/Demos/macosAppObjC/macosAppObjC/AppDelegate.m
@@ -12,7 +12,7 @@
 
 @import RollbarNotifier;
 
-//@import RollbarKSCrash;
+@import RollbarKSCrash;
 @import RollbarPLCrashReporter;
 
 __attribute__((noinline)) static void crashIt (void) {
@@ -55,14 +55,14 @@ - (void)applicationDidFinishLaunching:(NSNotification *)aNotification {
 
     // now, cause a crash:
 
-    //[self callTroublemaker];
-    //@throw NSInternalInconsistencyException;
-    //[self performSelector:@selector(die_die)];
-    //[self performSelector:NSSelectorFromString(@"crashme:") withObject:nil afterDelay:10];
-    //assert(NO);
-    //exit(0);
-    //crashIt();
-
+    [self callTroublemaker];
+    @throw NSInternalInconsistencyException;
+    [self performSelector:@selector(die_die)];
+    [self performSelector:NSSelectorFromString(@"crashme:") withObject:nil afterDelay:10];
+    assert(NO);
+    exit(0);
+    crashIt();
+    
 }
 
 

diff --git a/RollbarPLCrashReporter/Sources/RollbarPLCrashReporter/RollbarPLCrashCollector.m b/RollbarPLCrashReporter/Sources/RollbarPLCrashReporter/RollbarPLCrashCollector.m
@@ -20,12 +20,17 @@ +(void)initialize {
 
         // Configure our reporter:
         PLCrashReporterSignalHandlerType signalHandlerType =
-//#if !TARGET_OS_TV
-//#if !TARGET_OS_SIMULATOR
-//            PLCrashReporterSignalHandlerTypeMach;
+        // NOTE: looking at comments around the PLCRASH_FEATURE_MACH_EXCEPTIONS
+        //       definition in PLCrashReporter and matching it with actual experiences
+        //       on the current Apple OSs releases we should only use
+        //       the PLCrashReporterSignalHandlerTypeBSD option for now.
+        //       Leaving the alternative commented out for the reference in the future.
+//#if PLCRASH_FEATURE_MACH_EXCEPTIONS
+//        PLCrashReporterSignalHandlerTypeMach;
 //#else
-            PLCrashReporterSignalHandlerTypeBSD;
+        PLCrashReporterSignalHandlerTypeBSD;
 //#endif
+
         PLCrashReporterConfig *config =
         [[PLCrashReporterConfig alloc] initWithSignalHandlerType: signalHandlerType
                                            symbolicationStrategy: PLCrashReporterSymbolicationStrategyAll