Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve #644 #646

Merged
merged 4 commits into from
Jan 17, 2024
Merged

fix: resolve #644 #646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0affa98
Add fields to the scrubber field set.
csaba-ilonka-rollbar Nov 20, 2023
5bab495
Revert authz scrubbing.
csaba-ilonka-rollbar Nov 20, 2023
95e7b12
Update test.
csaba-ilonka-rollbar Jan 16, 2024
4c9f6e9
Revert "Update test."
csaba-ilonka-rollbar Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Rollbar/RollbarDataScrubbingHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
}

/// <summary>
/// Prevents a default instance of the <see cref="EmptyDisposable" /> class from being created.

Check warning on line 39 in Rollbar/RollbarDataScrubbingHelper.cs

View workflow job for this annotation

GitHub Actions / build (Release) 

XML comment has cref attribute 'EmptyDisposable' that could not be resolved

Check warning on line 39 in Rollbar/RollbarDataScrubbingHelper.cs

View workflow job for this annotation

GitHub Actions / build (Release) 

XML comment has cref attribute 'EmptyDisposable' that could not be resolved

Check warning on line 39 in Rollbar/RollbarDataScrubbingHelper.cs

View workflow job for this annotation

GitHub Actions / build (Release) 

XML comment has cref attribute 'EmptyDisposable' that could not be resolved

Check warning on line 39 in Rollbar/RollbarDataScrubbingHelper.cs

View workflow job for this annotation

GitHub Actions / build (Release) 

XML comment has cref attribute 'EmptyDisposable' that could not be resolved
/// </summary>
private RollbarDataScrubbingHelper()
{
Expand Down Expand Up @@ -94,13 +94,17 @@
return new HashSet<string>(
new[]
{
"Password",
"Password",
"password",
"passwd",
"confirm_password",
"password_confirmation",
"password_confirmation",
"AccessToken",
"accessToken",
"auth_token",
"authentication",
"Authentication",
"authentication",
"Secret",
"secret",
}
);
Expand Down
4 changes: 2 additions & 2 deletions SdkCommon.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@
</ItemGroup>

<PropertyGroup Label="SDK Release Essential Info">
<SdkVersion>5.2.0</SdkVersion> <!-- Required: major.minor.patch -->
<SdkVersion>5.2.1</SdkVersion> <!-- Required: major.minor.patch -->
<SdkVersionSuffix></SdkVersionSuffix> <!-- Optional. Examples: alpha, beta, preview, RC etc. -->
<SdkLtsRelease>false</SdkLtsRelease> <!-- Optional. Examples: false (default) or true. -->
<SdkReleaseNotes> <!-- Required -->

feat: resolve #630 - No option to set code_version at the config level in v5 of the SDK
fix: resolve #644 - Scrub access token in the message payload

</SdkReleaseNotes>

Expand Down
Loading