Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion performance #958

Merged
merged 7 commits into from
Nov 23, 2023
Merged

Completion performance #958

merged 7 commits into from
Nov 23, 2023

Conversation

markwpearce
Copy link
Collaborator

@markwpearce markwpearce commented Nov 22, 2023

Previously:

for each scope file is in
    on file text completion,
        for each scope the file is in
             get all symbols from entire symbol table

Now:

on file text completion,
    get symbols local to the completion position
    for each scope the file was in
         get symbols available at scope level
         get symbols based on namespace inclusion
   get the symbols from global scope

remove duplicates of same completion across different projects

@markwpearce markwpearce changed the base branch from master to release-0.66.0 November 22, 2023 14:58
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the build issue. Everything looks great!

@markwpearce markwpearce merged commit f3a1e58 into release-0.66.0 Nov 23, 2023
6 checks passed
@markwpearce markwpearce deleted the completion_performance branch November 23, 2023 00:43
@TwitchBronBron TwitchBronBron added this to the v1.0.0 milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants