Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes #17

wants to merge 2 commits into from

Conversation

ialxn
Copy link

@ialxn ialxn commented Jul 20, 2017

Small fixes:

  • prevents crash if keywords are not found in dictionary during print_metadata()
  • store key / value pairs in log_dict as strings and not as byte strings to prevent axes labels like
    b'Transmission'

ialxn added 2 commits July 20, 2017 12:14
This prevents e.g. axes labels like "b'Transmission'" in python 3.x

Signed-off-by: Ivo Alxneit <[email protected]>
@rohanisaac
Copy link
Owner

Thanks for the fixes, it looks good. It looks like it passes all of the automated tests, but I may take a look at it manually this evening just to make sure, and then merge the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants