Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Basic Implementation Of Graph #85

Merged
merged 11 commits into from
Oct 5, 2023
Merged

Conversation

shivamk23
Copy link
Contributor

Pull Request Checkboxes and descriptions

Description

This is a basic representation of Graphs , and you can extend it Based on your requirements. You might want to create separate classes for vertices and edges, implement a direct graph, or add additional functionality such as depth-first search or breadth-first-search.

Related/Fixes Issue

Issue : #67

Changes Made

I have added a basic implementation of graph which any beginner can easily able to understand.

  1. The add Edge method is used to add an undirected edge between two vertices.
  2. The print Graph method uses a lambda expression for concise printing.
  3. The Main class creates an instance of the Graph class and adds edges to it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats🙌 on your first pull request

@rohan472000
Copy link
Owner

Add description and Wikipedia links under comments in.java files

@shivamk23
Copy link
Contributor Author

okay sure @rohan472000

Added basic description and Wikipedia links.
@shivamk23
Copy link
Contributor Author

Done @rohan472000, now please merge my commit.

Copy link
Owner

@rohan472000 rohan472000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep those description and link at top not in middle.

@shivamk23 shivamk23 requested a review from rohan472000 October 5, 2023 06:09
@shivamk23
Copy link
Contributor Author

Added description and link at top. @rohan472000

@rohan472000
Copy link
Owner

You have proposed two .java files of graph...whats the difference in them?

@shivamk23
Copy link
Contributor Author

Sorry @rohan472000 it's my mistake, can you please merge my code. if everything is alright.

@rohan472000
Copy link
Owner

Sorry @rohan472000 it's my mistake, can you please merge my code. if everything is alright.

why so desperate to get your code merged?? after review and correction it will be merged.

Graphs/ImplementingGraphs.java Outdated Show resolved Hide resolved
@rohan472000 rohan472000 merged commit cd5834c into rohan472000:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants