Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_q()内のメンバ変数のthisポインタを明示 #128

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

rein0925
Copy link
Contributor

No description provided.

@rein0925 rein0925 requested a review from H1rono April 12, 2024 11:55
@H1rono
Copy link
Member

H1rono commented Apr 12, 2024

#56

Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

条件式のやつは他のとこもお願いします

@@ -167,25 +167,25 @@ inline void Schneider::state_equation() {
void Schneider::set_q() {
using std::abs;
if (abs(q[0] <= 0.4F)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

条件式内のthis抜けてる

}
while (q[3] < -schneider_PI) {
q[3] += 2 * schneider_PI;
this->q[3] += 2 * schneider_PI;
}

if (0 < q[2] && q[2] < schneider_PI) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここ以降もthis明示してください(Schneider::set_qの終わりまで)

@rein0925 rein0925 requested a review from H1rono April 12, 2024 12:48
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さ

@H1rono H1rono merged commit 65a5b7b into main Apr 12, 2024
1 check passed
@H1rono H1rono deleted the clang-tidy-set_q-static branch April 12, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants