Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File→folder #110

Merged
merged 7 commits into from
Apr 9, 2024
Merged

File→folder #110

merged 7 commits into from
Apr 9, 2024

Conversation

23-saho
Copy link
Contributor

@23-saho 23-saho commented Apr 4, 2024

No description provided.

@23-saho
zip展開についての説明（主にWindows）を追加しました。
dd2ec49 
インストールの説明文の順番を若干変更しました。
@23-saho
file→folder
75e4a90
@H1rono H1rono mentioned this pull request Apr 4, 2024
Closed
H1rono
H1rono requested changes Apr 5, 2024
View reviewed changes
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/assets以下に画像を置いてください、あと画像の名前をもうちょい考えてください

@Chikurin1014
Copy link
Contributor

ことばきつい

@H1rono
Copy link
Member

H1rono commented Apr 7, 2024

ごめんなさい

@23-saho
Copy link
Contributor Author

23-saho commented Apr 7, 2024

全然きつくないです
遅くなってすみません

H1rono
H1rono reviewed Apr 7, 2024
View reviewed changes
Copy link
Member

@H1rono H1rono left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

プレビューが間延びしちゃってるので、箇条書きの間はもうちょっと空行減らしても良さそうです
記述例↓

> #### Win
> 1. hogehoge
>     <img ... >
>
> 2. fugafuga
>     <img ... >
>
> 3. hugahuga
>     <img ... >
>
> #### Mac
> 1. foobar
> 2. fizzbazz

docs/04-environment-setup.md Outdated Show resolved Hide resolved
docs/04-environment-setup.md Outdated Show resolved Hide resolved
docs/04-environment-setup.md Outdated Show resolved Hide resolved
H1rono
H1rono reviewed Apr 7, 2024
View reviewed changes
docs/assets/zip_allopen.png Outdated Show resolved Hide resolved
docs/assets/zip_document.png Outdated Show resolved Hide resolved
docs/04-environment-setup.md Outdated Show resolved Hide resolved
docs/04-environment-setup.md Outdated Show resolved Hide resolved
H1rono
H1rono reviewed Apr 7, 2024
View reviewed changes
docs/04-environment-setup.md Outdated Show resolved Hide resolved
docs/04-environment-setup.md Show resolved Hide resolved
@H1rono
Copy link
Member

H1rono commented Apr 7, 2024

あと、画像の上の空行を消すように言ったけどやっぱりあった方がいいかも...?

H1rono
H1rono approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@H1rono H1rono merged commit 3e3c15e into main Apr 9, 2024
6 checks passed
@H1rono H1rono deleted the file→folder branch April 9, 2024 05:33
@H1rono H1rono mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H1rono H1rono H1rono approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@23-saho @Chikurin1014 @H1rono