Fix regression related to require_relative and fix integration tests
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerluan
changed the title
require_relative and fix integration tests
# Conflicts: # .github/workflows/kotlin-tests.yml # .github/workflows/swift-tests.yml # .ruby-version # Gemfile.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #64 which was caused by #56 and introduced in v2.1.0
Even though I identified what was causing the issue, I wanted to fix the integration tests so that these type of incidents don't happen again. Took me awhile to figure out what was causing this to only fail when installing specifically using Bundler, but issue was that in the old [broken] integration tests, we were installing the gem at the root folder of this project, which caused some coincidences in the filepaths to make
require_relativeto work, but once we changed the installation path, they stopped working.This was proven by first committing only the changes that make the tests fail:
And then committing the fix: