Clang-Tidy 17: modernize-loop-convert (#3833) #5
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # -Wno-c++17-extensions: Clang complains about nodiscard if the standard is not set to c++17. | |
| name: LinuxClang | |
| on: [push, pull_request] | |
| concurrency: | |
| group: ${{ github.ref }}-${{ github.head_ref }}-linux-clang | |
| cancel-in-progress: true | |
| jobs: | |
| # Build and install libamrex as AMReX CMake project | |
| # Note: this is an intentional "minimal" build that does not enable (many) options | |
| library_clang: | |
| name: [email protected] C++17 SP NOMPI Debug [lib] | |
| runs-on: ubuntu-20.04 | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Dependencies | |
| run: | | |
| .github/workflows/dependencies/dependencies_clang.sh 7 | |
| .github/workflows/dependencies/dependencies_clang-tidy.sh 12 | |
| .github/workflows/dependencies/dependencies_ccache.sh | |
| - name: Set Up Cache | |
| uses: actions/cache@v4 | |
| with: | |
| path: ~/.cache/ccache | |
| key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} | |
| restore-keys: | | |
| ccache-${{ github.workflow }}-${{ github.job }}-git- | |
| - name: Build & Install | |
| env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor"} | |
| run: | | |
| export CCACHE_COMPRESS=1 | |
| export CCACHE_COMPRESSLEVEL=10 | |
| export CCACHE_MAXSIZE=65M | |
| export CCACHE_EXTRAFILES=${{ github.workspace }}/.clang-tidy | |
| export CCACHE_LOGFILE=${{ github.workspace }}/ccache.log.txt | |
| ccache -z | |
| mkdir build | |
| cd build | |
| cmake .. \ | |
| -DCMAKE_BUILD_TYPE=Debug \ | |
| -DCMAKE_VERBOSE_MAKEFILE=ON \ | |
| -DCMAKE_INSTALL_PREFIX=/tmp/my-amrex \ | |
| -DAMReX_EB=ON \ | |
| -DAMReX_FORTRAN=ON \ | |
| -DAMReX_MPI=OFF \ | |
| -DAMReX_PLOTFILE_TOOLS=ON \ | |
| -DAMReX_PRECISION=SINGLE \ | |
| -DAMReX_PARTICLES_PRECISION=SINGLE \ | |
| -DCMAKE_C_COMPILER=$(which clang-7) \ | |
| -DCMAKE_CXX_COMPILER=$(which clang++-7) \ | |
| -DCMAKE_Fortran_COMPILER=$(which gfortran) \ | |
| -DCMAKE_CXX_COMPILER_LAUNCHER=ccache | |
| make -j 4 | |
| make install | |
| make test_install | |
| ${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt | |
| make -j4 -k -f clang-tidy-ccache-misses.mak \ | |
| CLANG_TIDY=clang-tidy-12 \ | |
| CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*" | |
| export PATH=/tmp/my-amrex/bin:$PATH | |
| which amrex_fcompare | |
| ctest --output-on-failure | |
| ccache -s | |
| du -hs ~/.cache/ccache | |
| tests_clang: | |
| name: [email protected] C++17 SP Particles DP Mesh Debug [tests] | |
| runs-on: ubuntu-22.04 | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Dependencies | |
| run: | | |
| .github/workflows/dependencies/dependencies_clang.sh 14 | |
| .github/workflows/dependencies/dependencies_clang-tidy.sh 14 | |
| .github/workflows/dependencies/dependencies_ccache.sh | |
| - name: Set Up Cache | |
| uses: actions/cache@v4 | |
| with: | |
| path: ~/.cache/ccache | |
| key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} | |
| restore-keys: | | |
| ccache-${{ github.workflow }}-${{ github.job }}-git- | |
| - name: Build & Install | |
| env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -O1 -Wnon-virtual-dtor"} | |
| # It's too slow with -O0 | |
| run: | | |
| export CCACHE_COMPRESS=1 | |
| export CCACHE_COMPRESSLEVEL=10 | |
| export CCACHE_MAXSIZE=200M | |
| export CCACHE_EXTRAFILES=${{ github.workspace }}/.clang-tidy | |
| export CCACHE_LOGFILE=${{ github.workspace }}/ccache.log.txt | |
| ccache -z | |
| mkdir build | |
| cd build | |
| cmake .. \ | |
| -DCMAKE_BUILD_TYPE=Debug \ | |
| -DCMAKE_VERBOSE_MAKEFILE=ON \ | |
| -DAMReX_EB=ON \ | |
| -DAMReX_ENABLE_TESTS=ON \ | |
| -DAMReX_FORTRAN=ON \ | |
| -DAMReX_MPI=OFF \ | |
| -DAMReX_PRECISION=DOUBLE \ | |
| -DAMReX_PARTICLES_PRECISION=SINGLE \ | |
| -DCMAKE_C_COMPILER=$(which clang-14) \ | |
| -DCMAKE_CXX_COMPILER=$(which clang++-14) \ | |
| -DCMAKE_Fortran_COMPILER=$(which gfortran) \ | |
| -DCMAKE_CXX_COMPILER_LAUNCHER=ccache | |
| make -j 4 | |
| ${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt | |
| make -j4 -k -f clang-tidy-ccache-misses.mak \ | |
| CLANG_TIDY=clang-tidy-14 \ | |
| CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*" | |
| ctest --output-on-failure | |
| ccache -s | |
| du -hs ~/.cache/ccache | |
| # Build 2D libamrex with configure | |
| configure-2d: | |
| name: Clang NOMPI Release [configure 2D] | |
| runs-on: ubuntu-22.04 | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Dependencies | |
| run: | | |
| .github/workflows/dependencies/dependencies_clang.sh 14 | |
| .github/workflows/dependencies/dependencies_clang-tidy.sh 14 | |
| .github/workflows/dependencies/dependencies_ccache.sh | |
| - name: Set Up Cache | |
| uses: actions/cache@v4 | |
| with: | |
| path: ~/.cache/ccache | |
| key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} | |
| restore-keys: | | |
| ccache-${{ github.workflow }}-${{ github.job }}-git- | |
| - name: Build & Install | |
| run: | | |
| export CCACHE_COMPRESS=1 | |
| export CCACHE_COMPRESSLEVEL=10 | |
| export CCACHE_MAXSIZE=25M | |
| export CCACHE_EXTRAFILES=${{ github.workspace }}/.clang-tidy | |
| export CCACHE_LOGFILE=${{ github.workspace }}/ccache.log.txt | |
| ccache -z | |
| ./configure --dim 2 --with-fortran no --comp llvm --with-mpi no | |
| make -j4 WARN_ALL=TRUE WARN_ERROR=TRUE XTRA_CXXFLAGS="-fno-operator-names" \ | |
| CCACHE=ccache | |
| make install | |
| ${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt | |
| make -j4 -k -f clang-tidy-ccache-misses.mak \ | |
| CLANG_TIDY=clang-tidy-14 \ | |
| CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*" | |
| ccache -s | |
| du -hs ~/.cache/ccache | |
| save_pr_number: | |
| if: github.event_name == 'pull_request' | |
| runs-on: ubuntu-latest | |
| steps: | |
| - name: Save PR number | |
| env: | |
| PR_NUMBER: ${{ github.event.number }} | |
| run: | | |
| echo $PR_NUMBER > pr_number.txt | |
| - uses: actions/upload-artifact@v4 | |
| with: | |
| name: pr_number | |
| path: pr_number.txt | |
| retention-days: 1 |