Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E for Triggered agregates #1865

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

Piotrk39
Copy link
Contributor

@Piotrk39 Piotrk39 commented Dec 17, 2024

Describe your changes

Adds test for aggregated number of events to be more then 0 when in trigger mode.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

@Piotrk39 Piotrk39 added enhancement New feature or request test This involves testing labels Dec 17, 2024
@Piotrk39 Piotrk39 marked this pull request as ready for review December 17, 2024 12:56
Copy link
Contributor

@jannisvisser jannisvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small changes.

Copy link
Contributor

@jannisvisser jannisvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks!

@jannisvisser jannisvisser merged commit 5cf86e2 into master Dec 23, 2024
8 checks passed
@jannisvisser jannisvisser deleted the feat.add-e2e-test-for-aggregates-in-trigger-mode branch December 23, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test This involves testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants