Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up husky & lint-staged AB#32125 #1854

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Dec 16, 2024

Describe your changes

Copy husky & lint-staged setup from 121, to make sure we properly run prettier and lint automatic fixes on commit, and only on staged files.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

@arsforza arsforza self-requested a review December 17, 2024 13:04
Copy link

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part looks good to me. I also found that we had to iterate a few times on the 121-platform until we ironed out all the kinks, so it might be ok to just get people using it and then adjust accordingly.

services/API-service/package.json Outdated Show resolved Hide resolved
@jannisvisser jannisvisser merged commit 3e7b688 into master Dec 19, 2024
7 checks passed
@jannisvisser jannisvisser deleted the chore.lint-staged branch December 19, 2024 11:10
log "Running custom pre-commit hook defined in ./husky/pre-commit"

# Prevent committing to "main"-branch:
if [ "$(git rev-parse --abbrev-ref HEAD)" = "main" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jannisvisser @arsforza This will not work because IBF does not have a main branch. It does have a master branch which we could use. Or create a main branch and use that instead of master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point I'll correct it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants