Add test for validating dynamic aggregates title. #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulfaraz
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
The new spelling is missing a n. Component.
| await this.page.waitForSelector('.leaflet-interactive'); | ||
|
|
||
| // Assert the that Aggregates title is visible and does not contain the text 'National View' | ||
| // 20 is the more or less number of admin boundaries that can be hovered over with Playwright to succesfully assert the title |
There was a problem hiding this comment.
I don't understand this magic number 20. Is it not sufficient to test one admin boundary and assume the others work the same way?
I feel I'm missing some testing-specific science here so correct me if I'm wrong.
| @@ -1,7 +1,6 @@ | |||
| import * as request from 'supertest'; | |||
| import TestAgent from 'supertest/lib/agent'; | |||
|
|
|||
| import { FloodsScenario } from '../../../services/API-service/src/scripts/enum/mock-scenario.enum'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds E2E test for validating aggregates title to be dynamic.
Checklist before requesting a review