Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: email design changes #1530

Merged
merged 29 commits into from
Jul 26, 2024
Merged

fix: email design changes #1530

merged 29 commits into from
Jul 26, 2024

Conversation

gulfaraz
Copy link
Member

@gulfaraz gulfaraz commented Jul 23, 2024 •
edited
Loading

Describe your changes

resolves #1512

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

gulfaraz added 25 commits July 23, 2024 12:38
@gulfaraz
build: remove duplicate port variable
c234990
@gulfaraz
build: update browser support for ng-18
2814481
@gulfaraz
fix: set header logo max height to 50px
81bf9f6
@gulfaraz
fix: use consistent font size, alignments, and button styles #1512
b02b4d8
@gulfaraz
fix: update copy
36c2969
@gulfaraz
fix: adjust spacing and widths
4da1da7
@gulfaraz
fix: follow mailchimp footer spec
1415ef0
@gulfaraz
fix: ibf footer email link
38c17ce
@gulfaraz
style: typo
aa10c30
@gulfaraz
style: typo
a4fafe9
@gulfaraz
fix: use disaster type label consistently
37bcee5
@gulfaraz
fix: use trigger threshold consistently
e623a13
@gulfaraz
fix: show timezone without underscore
d15654e
@gulfaraz
refactor: use timeZone instead of timezone consistently
a9c69a3
@gulfaraz
fix: reduce gap between warning and expected exposed
0d704a6
@gulfaraz
fi: use secondary buttons for social and about trigger
d327e29
@gulfaraz
fix: sort by lead time and threshold reached
eb00b89
@gulfaraz
fix: table spacing
545e981
@gulfaraz
fix: white space no wrap in alert title
135a207
@gulfaraz
feat: use ongoing instead of 0-lead-time
a62a512
@gulfaraz
fix: round the % value to 2 decimal places
a564d46
@gulfaraz
fix: show total affected if info is available
a7899c9
@gulfaraz
fix: update copy
02cbb87
@gulfaraz
data: use integers for population affected
5c209c8
@gulfaraz
fix: egypt heavy rainfall email
4613b37
@gulfaraz gulfaraz marked this pull request as ready for review July 24, 2024 14:29
@gulfaraz gulfaraz requested a review from arsforza July 24, 2024 14:29
@gulfaraz
Copy link
Member Author

@arsforza merge this before you proceed with the mjml changes #1527

@gulfaraz gulfaraz mentioned this pull request Jul 26, 2024
Closed
7 tasks
@gulfaraz gulfaraz merged commit 8a8f68f into master Jul 26, 2024
4 checks passed
@gulfaraz gulfaraz deleted the fix.email-design branch July 26, 2024 10:44
@gulfaraz gulfaraz mentioned this pull request Sep 29, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsforza arsforza arsforza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Design changes to alert emails
2 participants
@gulfaraz @arsforza