Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support email to too-late-tooltip + fix styling AB#23759 #1463

Merged
merged 2 commits into from
Sep 29, 2023
Merged

fix: add support email to too-late-tooltip + fix styling AB#23759 #1463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97e236c
fix: add support email to too-late-tooltip + fix styling AB#23759
jannisvisser Sep 22, 2023
af685cd
lint
jannisvisser Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion interfaces/IBF-dashboard/src/app/components/chat/chat.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@
></span>
<app-tooltip
*ngIf="isWarn"
[value]="'chat-component.common.warn-label.tooltip' | translate"
[value]="
'chat-component.common.warn-label.tooltip'
| translate: { supportEmailAddress: supportEmailAddress }
"
color="danger"
></app-tooltip>
</p>
Expand Down
4 changes: 3 additions & 1 deletion interfaces/IBF-dashboard/src/app/components/chat/chat.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { PlaceCodeService } from 'src/app/services/place-code.service';
import { EapAction } from 'src/app/types/eap-action';
import { EventState } from 'src/app/types/event-state';
import { TimelineState } from 'src/app/types/timeline-state';
import { environment } from '../../../environments/environment';
import { AggregatesService } from '../../services/aggregates.service';
import { TimelineService } from '../../services/timeline.service';
import { Actor } from '../../types/chat';
Expand Down Expand Up @@ -78,6 +79,7 @@ export class ChatComponent implements OnInit, OnDestroy {
public lastModelRunDate: string;
private lastModelRunDateFormat = 'cccc, dd LLLL HH:mm';
public isWarn = false;
public supportEmailAddress = environment.supportEmailAddress;

public actor = Actor;

Expand Down Expand Up @@ -533,7 +535,7 @@ export class ChatComponent implements OnInit, OnDestroy {
if (diff[durationUnit] > durationUnitValue + percentageOvertimeAllowed) {
this.isWarn = true;
} else {
this.isWarn = false;
this.isWarn = true;
}
};

Expand Down
2 changes: 1 addition & 1 deletion interfaces/IBF-dashboard/src/assets/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"common": {
"warn-label": {
"message": "Hello {{ name }}. The information in this portal is based on the model last run on <strong>{{lastModelRunDate}}</strong>.",
"tooltip": "The forecast presented on the portal might not be up to date as the model did not run successfully. Contact IBF support for further information."
"tooltip": "The forecast presented on the portal might not be up to date as the model did not run successfully. Contact {{supportEmailAddress}} for further information."
},
"revert-selection": "All",
"save-actions": {
Expand Down
10 changes: 5 additions & 5 deletions interfaces/IBF-dashboard/src/global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,12 +282,12 @@ app-tooltip {
}

.tooltip--container {
.popover-content {
.popover-viewport {
padding: 8px;
overflow: visible;
}
overflow: hidden;

ion-label {
padding-inline-start: 0;
ion-label {
padding-inline-start: 0;
}
}
}
Loading