Change test names add legend test init lines test

rodekruis · Nov 11, 2024 · dee0b79 · dee0b79
1 parent 702a1fd
commit dee0b79
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 24 deletions.
diff --git a/tests/e2e/Pages/MapComponent.ts b/tests/e2e/Pages/MapComponent.ts
@@ -188,6 +188,17 @@ class MapComponent extends DashboardPage {
     await expect(legendComponent).toBeVisible();
   }
 
+  async assertLegendElementIsNotVisible({
+    legendComponentName,
+  }: {
+    legendComponentName: string;
+  }) {
+    const legendComponent = this.legend.filter({
+      hasText: legendComponentName,
+    });
+    await expect(legendComponent).toBeHidden();
+  }
+
   async redCrossMarkersAreVisible() {
     // Wait for the page to load
     await this.page.waitForSelector('[alt="red-cross-branch-marker"]');

diff --git a/...hresholdLinesAreNotVisibleTrigger.spec.ts → ...esholdLinesAreNotVisibleNoTrigger.spec.ts b/...hresholdLinesAreNotVisibleTrigger.spec.ts → ...esholdLinesAreNotVisibleNoTrigger.spec.ts
@@ -36,10 +36,7 @@ test.beforeEach(async ({ page }) => {
 });
 
 test(
-  qase(
-    28,
-    '[No-trigger] GloFAS stations markers should be visible on "Legend", "Layer" and "Map"',
-  ),
+  qase(30, '[No-trigger] No "Alert Threshold Reached" lines are visible'),
   async ({ page }) => {
     const dashboard = new DashboardPage(page);
     const userState = new UserStateComponent(page);
@@ -56,14 +53,8 @@ test(
 
     await map.mapComponentIsVisible();
     await map.isLegendOpen({ legendOpen: true });
-    await map.isLayerMenuOpen({ layerMenuOpen: false });
-    await map.clickLayerMenu();
-    await map.validateCheckboxIsChekced({ layerName: 'Glofas stations' });
-    await map.assertLegendElementIsVisible({
-      legendComponentName: 'GloFAS No action',
+    await map.assertLegendElementIsNotVisible({
+      legendComponentName: 'Alert Threshold Reached',
     });
-
-    // GloFAS layer should be visible by default
-    await map.gloFASMarkersAreVisible();
   },
 );
diff --git a/...ThresholdLinesAreVisibleNoTrigger.spec.ts → ...oAlertThresholdIsVisibleNoTrigger.spec.ts b/...ThresholdLinesAreVisibleNoTrigger.spec.ts → ...oAlertThresholdIsVisibleNoTrigger.spec.ts
@@ -36,10 +36,7 @@ test.beforeEach(async ({ page }) => {
 });
 
 test(
-  qase(
-    28,
-    '[No-trigger] GloFAS stations markers should be visible on "Legend", "Layer" and "Map"',
-  ),
+  qase(29, '[No-trigger] No alert Threshold Reached is visible on the legend'),
   async ({ page }) => {
     const dashboard = new DashboardPage(page);
     const userState = new UserStateComponent(page);
@@ -56,14 +53,8 @@ test(
 
     await map.mapComponentIsVisible();
     await map.isLegendOpen({ legendOpen: true });
-    await map.isLayerMenuOpen({ layerMenuOpen: false });
-    await map.clickLayerMenu();
-    await map.validateCheckboxIsChekced({ layerName: 'Glofas stations' });
-    await map.assertLegendElementIsVisible({
-      legendComponentName: 'GloFAS No action',
+    await map.assertLegendElementIsNotVisible({
+      legendComponentName: 'Alert Threshold Reached',
     });
-
-    // GloFAS layer should be visible by default
-    await map.gloFASMarkersAreVisible();
   },
 );