fix: use early returns AB#25833

rodekruis · Jan 22, 2024 · 2b97eeb · 2b97eeb
1 parent 1f75b79
commit 2b97eeb
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/interfaces/IBF-dashboard/src/app/services/map.service.ts b/interfaces/IBF-dashboard/src/app/services/map.service.ts
@@ -1011,26 +1011,26 @@ export class MapService {
         color: triggered ? this.triggeredAreaColor : this.nonTriggeredAreaColor,
         weight: 5,
       };
-    } else if (area.stopped) {
+    }
+    if (area.stopped) {
       return {
         color: this.stoppedTriggerColor,
         weight: 5,
       };
-    } else if (!area.triggerValue || area.triggerValue < 1) {
-      return {
-        color: this.nonTriggeredAreaColor,
-        weight: 5,
-      };
-    } else if (!this.eventState?.event?.thresholdReached) {
+    }
+    if (
+      !area.triggerValue ||
+      area.triggerValue < 1 ||
+      !this.eventState?.event?.thresholdReached
+    ) {
       return {
         color: this.nonTriggeredAreaColor,
         weight: 5,
       };
-    } else {
-      return {
-        color: this.triggeredAreaColor,
-        weight: 5,
-      };
     }
+    return {
+      color: this.triggeredAreaColor,
+      weight: 5,
+    };
   };
 }